Bugfix 2040: Changed to get the default value for ModernTaxonomyPicker #2042
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect ITermInfo format
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AJIXuMuK
reviewed
Oct 12, 2025
| name: element.Label, | ||
| }); | ||
| }); | ||
| // item[field.InternalName].forEach((element) => { |
There was a problem hiding this comment.
Why did you comment this one?
There was a problem hiding this comment.
I'm not entirely sure anymore. It's been a while since the change. But I suspect it's because I wasn't sure what the purpose of the loop was at that point. It iterates over all the values and pushes them into the "selectedTags" array. And then the array is no longer used. In my opinion, the lines can be deleted entirely, including line 1314. But that was already commented out in the code. Maybe that's why I didn't delete it.
|
I have commented :) Do I have to resolve? I just added the comment for now 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Changed to get the default value for ModernTaxonomyPicker in the correct ITermInfo format. Bug mentioned in #2040
The "value" given to the ModernTaxonomyPicker field was { key: string; name: string; }. The picker is waiting for { id: string; labels: Array<..> }